Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): Enable 'next' and 'experimental' tags for rw upgrade #8024

Merged
merged 8 commits into from
Apr 7, 2023

Conversation

Josh-Walker-GM
Copy link
Collaborator

@Josh-Walker-GM Josh-Walker-GM commented Apr 6, 2023

Problem
We want to allow users to select the next and experimental tags when running yarn rw upgrade --tag [tag] but this is currently not allowed.

Changes

  1. Add next and experimental to the allowed tags list.
  2. Update the docs to reflect the updated tag options.

@Josh-Walker-GM Josh-Walker-GM added the release:chore This PR is a chore (means nothing for users) label Apr 6, 2023
@replay-io
Copy link

replay-io bot commented Apr 6, 2023

16 replays were recorded for e8227d4.

image 0 Failed
image 16 Passed
    requireAuth graphql checks
          ```
          locator.waitFor: Target closed
          =========================== logs ===========================
          waiting for locator('.rw-form-error-title').locator('text=You don\'t have permission to do that') to be visible
          ============================================================
          ```
        </ol>
      </details>
      <li><a href=https://app.replay.io/recording/f4236b1e-86e0-4110-946d-7c90afbae681>useAuth hook, auth redirects checks</a></li>
      <li><a href=https://app.replay.io/recording/c2e4f55d-2471-4fb1-a52d-31d9ad6f8b79>Check that a specific blog post is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/3785730d-3265-4122-9d10-5760f1ba79b3>Check that about is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/97ca2f27-3a0e-42d1-bd8a-a815b395255e>Check that homepage is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/002682bb-345f-4172-a909-16be460572d1>Check that meta-tags are rendering the correct dynamic data</a></li>
      <li><a href=https://app.replay.io/recording/4ba511a4-8dc6-4571-bca6-09fa5937cf36>Check that you can navigate from home page to specific blog post</a></li>
      <li><a href=https://app.replay.io/recording/1135efe6-782c-4eaf-afc0-c11300c6ded9>Waterfall prerendering (nested cells)</a></li>
      <li><a href=https://app.replay.io/recording/ee49d67e-0235-4248-a6a1-a2b636a11dae>RBAC: Admin user should be able to delete contacts</a></li>
      <li><a href=https://app.replay.io/recording/73bb9a83-1110-460a-b01d-220863f2c8cf>RBAC: Should not be able to delete contact as non-admin user</a></li>
      <li><a href=https://app.replay.io/recording/f041fb75-ba84-44f9-8aa5-5cc3eadf9d42>Smoke test with dev server</a></li>
      <li><a href=https://app.replay.io/recording/5aaf82bd-22a3-4a80-b31f-00b0d1ba29e7>Smoke test with rw serve</a></li>
      <li><a href=https://app.replay.io/recording/658a4dc7-9714-4a5c-ab9f-076d1a2da559>Loads Cell mocks when Cell is nested in another story</a></li>
      <li><a href=https://app.replay.io/recording/daac9da6-ba19-4e30-853b-3b4882fd3058>Loads Cell Stories</a></li>
      <li><a href=https://app.replay.io/recording/e399be0a-5233-4aa8-a32f-7362f222353b>Loads MDX Stories</a></li>
      <li><a href=https://app.replay.io/recording/82ce1942-60f7-4630-9817-9e07d354484c>Mocks current user, and updates UI while dev server is running</a></li>
      

View test run on Replay ↗︎

@Josh-Walker-GM
Copy link
Collaborator Author

Reverted to simply add "next" and "experimental" to the allowed list of tags.

I don't understand why we have an "experimental" tag given that we expect users to simply use the full SEMVER version for different experimental branches/features.

@Tobbe
Copy link
Member

Tobbe commented Apr 7, 2023

I don't understand why we have an "experimental" tag given that we expect users to simply use the full SEMVER version for different experimental branches/features.

Let's discuss this on the next core team meeting before we merge this PR please 🙂

@Tobbe Tobbe marked this pull request as draft April 7, 2023 19:03
Copy link
Contributor

@thedavidprice thedavidprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @Josh-Walker-GM I made some copy changes. Could you do a final check/confirmation and then merge?

Looping in @jtoar if we want to cherry-pick this into v4.5-RC

@thedavidprice
Copy link
Contributor

@Tobbe I'm asking to merge this before next meeting. Happy to discuss further.

@thedavidprice thedavidprice marked this pull request as ready for review April 7, 2023 19:06
@Josh-Walker-GM
Copy link
Collaborator Author

I checked again locally and things looked and worked fine. I'll enable auto-merge but this might get stuck on the flaky logger CI error for a little bit until that's resolved separately.

@Josh-Walker-GM Josh-Walker-GM enabled auto-merge (squash) April 7, 2023 19:28
@jtoar jtoar disabled auto-merge April 7, 2023 23:55
@jtoar jtoar merged commit 3b5e4a3 into main Apr 7, 2023
@jtoar jtoar deleted the jgmw-allow-experimental-update branch April 7, 2023 23:55
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Apr 7, 2023
jtoar pushed a commit that referenced this pull request Apr 11, 2023
…8024)

* Add 'next' and 'experimental' tags for rw upgrade command

* update cli help message

* Allow experimental tags of the form 'experimental-*'

* Revert to single experimental tag support

* Update packages/cli/src/commands/upgrade.js

* Update docs/docs/cli-commands.md

* Update packages/cli/src/commands/upgrade.js

---------

Co-authored-by: David Price <thedavid@thedavidprice.com>
jtoar pushed a commit that referenced this pull request Apr 11, 2023
…8024)

* Add 'next' and 'experimental' tags for rw upgrade command

* update cli help message

* Allow experimental tags of the form 'experimental-*'

* Revert to single experimental tag support

* Update packages/cli/src/commands/upgrade.js

* Update docs/docs/cli-commands.md

* Update packages/cli/src/commands/upgrade.js

---------

Co-authored-by: David Price <thedavid@thedavidprice.com>
@jtoar jtoar modified the milestones: next-release, v4.5.0 Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants