Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rw-dev): with vite #7943

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Conversation

dac09
Copy link
Collaborator

@dac09 dac09 commented Mar 28, 2023

What?

Recent changes to split out internal into project-config broke the RW vite dev handler, with the error:

web | file:///Users/dac09/Projects/nodeconf-rw-recipe/node_modules/@redwoodjs/vite/bins/rw-vite-dev.mjs:3
web | import { getPaths } from '@redwoodjs/project-config'
web |          ^^^^^^^^
web | SyntaxError: Named export 'getPaths' not found. The requested module '@redwoodjs/project-config' is a CommonJS module, which may not support all module.exports as named exports.
web | CommonJS modules can always be imported via the default export, for example using:
web | import pkg from '@redwoodjs/project-config';
web | const { getPaths } = pkg;

This PR fixes it according to the suggestion in the error

@dac09 dac09 changed the title Fix rw-dev with vite fix(rw-dev): with vite Mar 28, 2023
@dac09 dac09 enabled auto-merge (squash) March 28, 2023 04:56
@dac09 dac09 added the release:fix This PR is a fix label Mar 28, 2023
@replay-io
Copy link

replay-io bot commented Mar 28, 2023

16 replays were recorded for 9f515b4.

image 0 Failed
image 16 Passed
    requireAuth graphql checks
          ```
          locator.waitFor: Target closed
          =========================== logs ===========================
          waiting for locator('.rw-form-error-title').locator('text=You don\'t have permission to do that') to be visible
          ============================================================
          ```
        </ol>
      </details>
      <li><a href=https://app.replay.io/recording/320976d2-6304-4828-b6d3-b58589a8a4dd>useAuth hook, auth redirects checks</a></li>
      <li><a href=https://app.replay.io/recording/23eb528d-3840-497b-8261-908dce883bde>Check that a specific blog post is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/2374fa03-3b4a-415c-a707-4f057a38186d>Check that about is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/b0a4d069-9de5-416c-8143-a056983754af>Check that homepage is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/566234ec-80a3-425f-8915-75a2bee7ad57>Check that meta-tags are rendering the correct dynamic data</a></li>
      <li><a href=https://app.replay.io/recording/61883424-3f4c-4fa7-afc2-19423b7d4048>Check that you can navigate from home page to specific blog post</a></li>
      <li><a href=https://app.replay.io/recording/9388faf7-6597-47da-a047-4c4b284298f5>Waterfall prerendering (nested cells)</a></li>
      <li><a href=https://app.replay.io/recording/196dccd1-8cdd-4319-930b-628be32282d2>RBAC: Admin user should be able to delete contacts</a></li>
      <li><a href=https://app.replay.io/recording/4f95c409-7bf7-4762-bd1a-3ba9689b484c>RBAC: Should not be able to delete contact as non-admin user</a></li>
      <li><a href=https://app.replay.io/recording/ec1ebb5c-af53-436e-be71-b84be4329f72>Smoke test with dev server</a></li>
      <li><a href=https://app.replay.io/recording/4dfd3d5f-3770-4e25-8b89-9c4b242ec307>Smoke test with rw serve</a></li>
      <li><a href=https://app.replay.io/recording/2fbc288b-3a74-47fd-bc37-f69933b54e7c>Loads Cell mocks when Cell is nested in another story</a></li>
      <li><a href=https://app.replay.io/recording/f497dff8-7650-4947-ad63-cca3efc5c1a6>Loads Cell Stories</a></li>
      <li><a href=https://app.replay.io/recording/35e89989-cd9a-4fc3-ab21-08ba95bb18f5>Loads MDX Stories</a></li>
      <li><a href=https://app.replay.io/recording/b3f1f7f2-80f3-492a-aade-504f6db03304>Mocks current user, and updates UI while dev server is running</a></li>
      

View test run on Replay ↗︎

@dac09 dac09 merged commit f6664c9 into redwoodjs:main Mar 28, 2023
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Mar 28, 2023
jtoar pushed a commit that referenced this pull request Mar 28, 2023
@jtoar jtoar modified the milestones: next-release, v4.5.0 Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants