Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share template variables between pages and models in scaffold #7894

Merged
merged 4 commits into from
Mar 24, 2023

Conversation

orta
Copy link
Contributor

@orta orta commented Mar 23, 2023

This might be a reasonable answer to backwards compat in the templates, couldn't find a good way to test it though (other than all the existing tests not crashing)

@replay-io
Copy link

replay-io bot commented Mar 23, 2023

16 replays were recorded for 14a16de.

image 0 Failed
image 16 Passed
    requireAuth graphql checks
          ```
          locator.waitFor: Target closed
          =========================== logs ===========================
          waiting for locator('.rw-form-error-title').locator('text=You don\'t have permission to do that') to be visible
          ============================================================
          ```
        </ol>
      </details>
      <li><a href=https://app.replay.io/recording/53ca2695-2525-4bef-aebe-0054f21f7a87>useAuth hook, auth redirects checks</a></li>
      <li><a href=https://app.replay.io/recording/abbfc561-8281-4ab0-93f2-45e07175981f>Check that a specific blog post is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/f8c5f122-ec7e-4d31-8667-53ab53239883>Check that about is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/ca7bc344-7829-468d-a97e-56bd5a210460>Check that homepage is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/f48e78d3-ee82-449b-865e-f88dbadeb316>Check that meta-tags are rendering the correct dynamic data</a></li>
      <li><a href=https://app.replay.io/recording/681ef534-04bf-492c-890d-b0947755afa2>Check that you can navigate from home page to specific blog post</a></li>
      <li><a href=https://app.replay.io/recording/e7cfbffd-2e08-4054-9f33-0135341d5ea3>Waterfall prerendering (nested cells)</a></li>
      <li><a href=https://app.replay.io/recording/1fcabfc3-f4ef-42e5-9cb9-d45c9c20bf8c>RBAC: Admin user should be able to delete contacts</a></li>
      <li><a href=https://app.replay.io/recording/6b81940f-7b77-41c3-ac40-67ecc6bbbde7>RBAC: Should not be able to delete contact as non-admin user</a></li>
      <li><a href=https://app.replay.io/recording/21207068-9d9a-48bc-baa3-2cb1628fed6c>Smoke test with dev server</a></li>
      <li><a href=https://app.replay.io/recording/ab8aff48-ee7e-467b-b6fd-7b30176fd059>Smoke test with rw serve</a></li>
      <li><a href=https://app.replay.io/recording/2391458a-de90-4b19-b0a8-d01023aaad23>Loads Cell mocks when Cell is nested in another story</a></li>
      <li><a href=https://app.replay.io/recording/3049f8ac-f506-4b31-86ab-d274947d8bd4>Loads Cell Stories</a></li>
      <li><a href=https://app.replay.io/recording/ddae8c3b-d99a-40d7-9e25-c0c1ea581a79>Loads MDX Stories</a></li>
      <li><a href=https://app.replay.io/recording/5c512f84-c396-4d22-a6fc-d9fa5a567357>Mocks current user, and updates UI while dev server is running</a></li>
      

View test run on Replay ↗︎

@dac09 dac09 requested a review from cannikin March 23, 2023 15:20
@dac09 dac09 added the release:fix This PR is a fix label Mar 23, 2023
@dac09
Copy link
Collaborator

dac09 commented Mar 23, 2023

@cannikin I think this is your territory, would you like to take a look please?

@cannikin
Copy link
Member

It's been a while, I don't really recognize any of this code, but it looks like it's just reorganizing a bunch of functions/vars into a object that's then destructured at the end? Seems fine to me!

@orta
Copy link
Contributor Author

orta commented Mar 23, 2023

Yep, nothing new here 👍🏻

@jtoar jtoar added the fixture-ok Override the test project fixture check label Mar 23, 2023
@jtoar jtoar merged commit 22327b0 into redwoodjs:main Mar 24, 2023
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixture-ok Override the test project fixture check release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants