Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forms: Export EmptyAsValue #7656

Merged
merged 3 commits into from
Feb 20, 2023
Merged

Forms: Export EmptyAsValue #7656

merged 3 commits into from
Feb 20, 2023

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Feb 19, 2023

When building custom components that you want to be compatible with existing form components it'd be nice to be able to use the same type for emptyAs. Right now you have to copy/paste null | 'undefined' | 0 | '' and hope it never changes

@Tobbe Tobbe added the release:feature This PR introduces a new feature label Feb 19, 2023
@jtoar jtoar enabled auto-merge (squash) February 20, 2023 20:53
@jtoar jtoar merged commit 98b1ee7 into redwoodjs:main Feb 20, 2023
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Feb 20, 2023
@Tobbe Tobbe deleted the tobbe-export-emptyAs branch February 20, 2023 23:51
jtoar pushed a commit that referenced this pull request Feb 21, 2023
jtoar pushed a commit that referenced this pull request Feb 22, 2023
jtoar pushed a commit that referenced this pull request Feb 22, 2023
dac09 added a commit to dac09/redwood that referenced this pull request Feb 28, 2023
* 'main' of github.com:redwoodjs/redwood: (21 commits)
  chore(deps): update dependency @types/uuid to v9.0.1 (redwoodjs#7680)
  chore(deps): update dependency @replayio/playwright to v0.3.23 (redwoodjs#7677)
  chore(deps): update dependency @npmcli/arborist to v6.2.3 (redwoodjs#7675)
  chore(deps): update dependency @envelop/types to v3.0.2 (redwoodjs#7674)
  chore: add codemod for clerk fix in v4.2.0 (redwoodjs#7676)
  chore(deps): update dependency @clerk/types to v3.28.1 (redwoodjs#7652)
  chore(deps): update dependency @envelop/testing to v5.0.6 (redwoodjs#7673)
  Update directives.md (redwoodjs#7670)
  fix(deps): update dependency vscode-languageserver-types to v3.17.3 (redwoodjs#7636)
  Fix `yarn rw exec` to set nonzero exit code on error (redwoodjs#7660)
  fix(deps): update dependency core-js to v3.28.0 (redwoodjs#7666)
  fix(deps): update dependency @clerk/clerk-sdk-node to v4.7.4 (redwoodjs#7663)
  fix(deps): update dependency vite to v4.1.3 (redwoodjs#7664)
  fix(deps): update dependency @fastify/url-data to v5.3.1 (redwoodjs#7665)
  fix(deps): update dependency yargs to v17.7.1 (redwoodjs#7667)
  fix(clerk): Remove privateMetadata property from getCurrentUser (redwoodjs#7668)
  chore(deps): update dependency esbuild to v0.17.10 (redwoodjs#7662)
  chore(deps): bump setup of Chakra UI to V2 (redwoodjs#7649)
  Forms: Export EmptyAsValue (redwoodjs#7656)
  Update useRequireAuth docs to v4 auth (redwoodjs#7646)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:feature This PR introduces a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants