Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(generators): Refactor cell tests for performance #6925

Merged
merged 5 commits into from
Nov 24, 2022

Conversation

dac09
Copy link
Collaborator

@dac09 dac09 commented Nov 21, 2022

This just removes the beforeAll block, and moves tests into describe or test blocks, with only the variables that are needed in that group.

I think this is the last one....

Closes #6451

@dac09 dac09 requested a review from jtoar November 21, 2022 10:56
@dac09 dac09 self-assigned this Nov 21, 2022
@dac09 dac09 added release:chore This PR is a chore (means nothing for users) action/add-to-cycle labels Nov 21, 2022
@dac09 dac09 added the fixture-ok Override the test project fixture check label Nov 21, 2022
@jtoar jtoar enabled auto-merge (squash) November 24, 2022 16:00
@jtoar jtoar merged commit 42d9754 into redwoodjs:main Nov 24, 2022
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Nov 24, 2022
@jtoar jtoar modified the milestones: next-release, v3.7.0 Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixture-ok Override the test project fixture check release:chore This PR is a chore (means nothing for users)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Chore]: @redwoodjs/cli tests are slow and sometimes cause timeouts
2 participants