chore(generate): Refactor how page tests are written #6825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
10 replays were recorded for 507a94a.
|
jtoar
approved these changes
Nov 9, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Nov 10, 2022
* chore(generate): Refactor how page tests are written to help with memory usage/speed * fix incorrect snapshot
jtoar
pushed a commit
that referenced
this pull request
Nov 10, 2022
* chore(generate): Refactor how page tests are written to help with memory usage/speed * fix incorrect snapshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...to help with memory usage/speed.
This just removes the
beforeAllblock, and moves tests into describe or test blocks, with only the variables that are needed in that group.Related to #6451