Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds docs about removing any UserCredential relationship manually from generated User SDL #6672

Merged
merged 4 commits into from
Oct 12, 2022

Conversation

cannikin
Copy link
Member

In response to this Issue: #5841, specifically the comments that start here: #5841 (comment)

These users were generating a User SDL after making the UserCredential schema changes. The SDL/scaffold generator would add a UserCredential type to the User SDL, assuming that you wanted to access those child records. Since there was no requisite UserCredential SDL file, that type was undefined, which makes the api server blow up:

image

We plan on adding this field name to our upcoming allow/blocklist of generated fields (along with stuff like hashedPassword and salt) so that it doesn't not get generated by default and confuse folks who suddenly start getting errors.

@cannikin cannikin self-assigned this Oct 12, 2022
@cannikin cannikin added release:chore This PR is a chore (means nothing for users) release:docs This PR only updates docs labels Oct 12, 2022
@cannikin
Copy link
Member Author

cannikin commented Oct 12, 2022

@jtoar I would have listed this as "docs only" but it does include an update to the post-install message in one of the setup commands. But if there's an option to re-deploy the docs site, we could do that: I backported the new doc message to the 3.0 and 3.1 versioned docs dirs.

@cannikin cannikin removed the release:docs This PR only updates docs label Oct 12, 2022
@cannikin cannikin added the fixture-ok Override the test project fixture check label Oct 12, 2022
@cannikin cannikin merged commit 8bfc90c into main Oct 12, 2022
@cannikin cannikin deleted the rc-usercredentials-sdl branch October 12, 2022 18:09
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Oct 12, 2022
@jtoar jtoar modified the milestones: next-release, v3.3.0 Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixture-ok Override the test project fixture check release:chore This PR is a chore (means nothing for users)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants