add example for controlled components #6519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the alternative for custom input fields when useRegister can't be used.
jtoar
suggested changes
Oct 5, 2022
There was a problem hiding this comment.
@m-raschle thanks this is awesome! Went through it and made a few suggestions. Let me know if anything's unclear. The code worked great, just tweaked things for readability and sometimes just for personal preference. But otherwise looks good
Co-authored-by: Dominic Saadi <dominiceliassaadi@gmail.com>
only import type to make clear that all you need is the type Co-authored-by: Dominic Saadi <dominiceliassaadi@gmail.com>
Co-authored-by: Dominic Saadi <dominiceliassaadi@gmail.com>
jtoar
reviewed
Oct 7, 2022
jtoar
approved these changes
Oct 7, 2022
There was a problem hiding this comment.
Thanks @m-raschle! This is a great addition, let's get it merged.
github-actions bot
pushed a commit
that referenced
this pull request
Oct 7, 2022
* add example for controlled components the alternative for custom input fields when useRegister can't be used. * readability change Co-authored-by: Dominic Saadi <dominiceliassaadi@gmail.com> * change props import only import type to make clear that all you need is the type Co-authored-by: Dominic Saadi <dominiceliassaadi@gmail.com> * remove last line Co-authored-by: Dominic Saadi <dominiceliassaadi@gmail.com> * pluralize props * add a title * change hyperlink * Update docs/docs/forms.md Co-authored-by: Dominic Saadi <dominiceliassaadi@gmail.com>
jtoar
added a commit
that referenced
this pull request
Oct 7, 2022
* add example for controlled components the alternative for custom input fields when useRegister can't be used. * readability change Co-authored-by: Dominic Saadi <dominiceliassaadi@gmail.com> * change props import only import type to make clear that all you need is the type Co-authored-by: Dominic Saadi <dominiceliassaadi@gmail.com> * remove last line Co-authored-by: Dominic Saadi <dominiceliassaadi@gmail.com> * pluralize props * add a title * change hyperlink * Update docs/docs/forms.md Co-authored-by: Dominic Saadi <dominiceliassaadi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the alternative for custom input fields when useRegister can't be used.