Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: RedwoodJS Directives - Make it clearer that can use directiveArgs in Transformer directive #6497

Merged
merged 5 commits into from
Nov 28, 2022
Merged

Chore: RedwoodJS Directives - Make it clearer that can use directiveArgs in Transformer directive #6497

merged 5 commits into from
Nov 28, 2022

Conversation

dthyresson
Copy link
Contributor

When working on https://github.com/redwoodjs/redwood-office-hours/tree/main/2022-09-28-rest-directive to implement a Rest Directive, I noticed that it

  1. Was not clean that you could provide directiveArgs with a Transformer directive
  2. How the directiveArgs was included in the async vs non-async case was inconsistent

This PR:

  1. Adds docs to show that directiveArgs can be used
  2. Consistently includes the directiveArgs when passing to onResolvedValue

@dthyresson dthyresson added the release:chore This PR is a chore (means nothing for users) label Oct 3, 2022
@dthyresson dthyresson requested a review from dac09 November 9, 2022 18:34
@replay-io
Copy link

replay-io bot commented Nov 9, 2022 •
edited
Loading

10 replays were recorded for 8b528a7.

image 0 Failed
image 10 Passed

View test run on Replay ↗︎

@dthyresson dthyresson enabled auto-merge (squash) November 28, 2022 18:45
@dthyresson dthyresson merged commit 286dfe0 into redwoodjs:main Nov 28, 2022
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Nov 28, 2022
@redwoodjs-bot
Copy link

redwoodjs-bot bot commented Nov 28, 2022

🔔 @jtoar, @Tobbe—I couldn't cherry pick this one. If you want it in the next release, you'll have to cherry pick it manually.

dac09 added a commit that referenced this pull request Nov 29, 2022
@dac09
Merge branch 'main' of github.com:redwoodjs/redwood into feat/dc-kc-e…
3a02534 
…xperimental-vite-optin

* 'main' of github.com:redwoodjs/redwood:
  fix(deps): update dependency css-loader to v6.7.2 (#6976)
  auth0 and netlify auth packages (#6922)
  fix(deps): update graphqlcodegenerator monorepo (#6980)
  fix(deps): update dependency react-hook-form to v7.39.7 (#6978)
  fix(deps): update dependency fastify-raw-body to v4.1.3 (#6977)
  chore(deps): update dependency esbuild to v0.15.16 (#6975)
  chore(deps): update babel monorepo (#6974)
  Make it clearer that can use directiveArgs in transformer directive (#6497)
  docs: Adds Troubleshooting Section to Serverless (#6498)
  fix: extractCookie from GraphiQLHeader (#6894) (#6969)
  Render Deploy: Define plan in template (#6905)
  fix launch.json (#6972)
  small tweak to flightcontrol deploy docs (#6973)
@jtoar jtoar modified the milestones: next-release, v4.0.0 Dec 8, 2022
jtoar pushed a commit that referenced this pull request Dec 8, 2022
@dthyresson @dac09 @jtoar
Make it clearer that can use directiveArgs in transformer directive (#…
a462cb7 
…6497)

Co-authored-by: Daniel Choudhury <dannychoudhury@gmail.com>
@jtoar jtoar modified the milestones: v4.0.0, next-release, v3.7.0, next-release-patch, v3.6.1 Dec 8, 2022
@jtoar jtoar modified the milestones: v3.6.1, next-release-patch Dec 9, 2022
jtoar pushed a commit that referenced this pull request Dec 10, 2022
@dthyresson @dac09 @jtoar
Make it clearer that can use directiveArgs in transformer directive (#…
676c5b3 
…6497)

Co-authored-by: Daniel Choudhury <dannychoudhury@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dac09 dac09 dac09 approved these changes

Assignees

@dthyresson dthyresson

Labels
release:chore This PR is a chore (means nothing for users)
Projects
Main
Status: Done
Milestone
v3.6.1
Development

Successfully merging this pull request may close these issues.
3 participants
@dthyresson @dac09 @jtoar