Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update flightcontrol deploy config #6494

Merged
merged 3 commits into from
Oct 3, 2022
Merged

Conversation

flybayer
Copy link
Contributor

@flybayer flybayer commented Oct 3, 2022

We have a new nixpacks build option that automatically detects package manager versions, node versions, etc. So install command is no longer needed and no longer need to manually install yarn stable version.

@noire-munich
Copy link
Collaborator

Thanks for the update @flybayer 👍🏻 should be merged in no time.

@noire-munich noire-munich self-requested a review October 3, 2022 09:46
@noire-munich noire-munich added the fixture-ok Override the test project fixture check label Oct 3, 2022
@noire-munich
Copy link
Collaborator

@jtoar just wanted to double check on this one, I added the fixture-ok label, is this indeed the correct move for our case?
I'm rolling back on my approval because of this only.

@Tobbe Tobbe added the release:chore This PR is a chore (means nothing for users) label Oct 3, 2022
@Tobbe
Copy link
Member

Tobbe commented Oct 3, 2022

@noire-munich Yes, fixture-ok is the right choice. Our test project doesn't use this file and isn't affected by this change in any way.

If you're unsure it's always okay to just rebuild the test project fixture and commit the changes. That label is just a quick way around having to do that if you know it's not really needed

@Tobbe Tobbe enabled auto-merge (squash) October 3, 2022 11:11
@noire-munich
Copy link
Collaborator

Thanks @Tobbe ! This confirms how I thought about it, it's good to know 👍

@Tobbe Tobbe mentioned this pull request Oct 3, 2022
4 tasks
@jtoar
Copy link
Contributor

jtoar commented Oct 3, 2022

Thanks @noire-munich! Yeah let's get this merged so we can hand it off to the deploy target CI repo.

@jtoar jtoar disabled auto-merge October 3, 2022 19:25
@jtoar jtoar merged commit 6e77af7 into redwoodjs:main Oct 3, 2022
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Oct 3, 2022
@jtoar jtoar modified the milestones: next-release, v3.2.0 Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixture-ok Override the test project fixture check release:chore This PR is a chore (means nothing for users) topic/cli topic/deployment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants