-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Decimal in scenario tests #6491
Conversation
this is a way cleaner solution to the types problem! passing in the type "metadata" is a great idea @Tobbe |
I had to come up with another solution for Decimal. Can't use a regexp to find Decimals that also doesn't match Float 🙂 And then I realized I could use the same solution for dates too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works locally and checks out with the Prisma docs!
@Tobbe this is ready to go on your end right? I can take care of merging it from here. |
Co-authored-by: Dominic Saadi <dominiceliassaadi@gmail.com>
Fixes #6429
We were converting Decimals to strings, and then comparing those to numbers. That doesn't work. Now we keep them as Decimals, which lets us compare them to numbers.