-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting query name in cell generator #6442
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
8a2ba48
Added cell query name flag
Josh-Walker-GM e801074
Added cell query name flag
Josh-Walker-GM d911cab
Added newline bodge and caused git issue
Josh-Walker-GM f98c173
Changed to use listr2 and enquirer prompts - breaking
Josh-Walker-GM c37cf57
Merge pull request #1 from Josh-Walker-GM/generated-query-name-nolistr
Josh-Walker-GM a145737
Revert "Changed to use listr2 and enquirer prompts - breaking"
Josh-Walker-GM da09786
Merge pull request #2 from Josh-Walker-GM/revert-1-generated-query-na…
Josh-Walker-GM 2674363
Removed prompt, tidied condition
Josh-Walker-GM 5453a06
Deny any duplicate name regardless of force. Updated flag description
Josh-Walker-GM ea22b6e
Fix error message
Josh-Walker-GM 0ecc92f
Merge branch 'main' into generated-query-name
Josh-Walker-GM 2378c50
updated test-project fixtures
Josh-Walker-GM ee147c6
removed unusused prompts import
Josh-Walker-GM cc71bc2
Add tests for query name in cell generator
dac09 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey all, saw this change when merging the patch release branch back into main. Could we go without this change, or is this package necessary for this PR? I noticed we didn't change the CRWA template, so something may be missing if this one is necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting that it shows up here now.
Danny and I discovered a while ago that it's been missing as a web side dependency.
Let me try to find a PR that's relevant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the PR
https://github.com/redwoodjs/redwood/pull/6221/files
humanize-string should not be a dep in the test projectAckshually... Let me check again
So. That PR I linked above removed the import of humanize-string from all the scaffolded components in the test project (and any actual RW app too). Instead it moved to the new /web/src/lib/formatters.ts file.
So it should be added as a dependency to the web side as soon as you scaffold a model.
Previously it wasn't an explicit dependency on the web package. But it was a dependency on the cli package, so we got away with it.