-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(crwa): Fixes telemetry issues on CRWA #6434
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Did a review of the code and LGTM from what I understand. However, the https://github.com/redwoodjs/redwood/blob/main/packages/telemetry/README.md Maybe add the description above as well as some of the helpful enviers for debugging? |
Tobbe
reviewed
Sep 21, 2022
Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>
jtoar
pushed a commit
that referenced
this pull request
Sep 24, 2022
Co-authored-by: David Thyresson <dthyresson@gmail.com>
jtoar
pushed a commit
that referenced
this pull request
Sep 24, 2022
Co-authored-by: David Thyresson <dthyresson@gmail.com>
jtoar
pushed a commit
that referenced
this pull request
Sep 24, 2022
Co-authored-by: David Thyresson <dthyresson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diagnosis of the issue
The telmetry script was failing, because it couldn't find the module typescript.
You can see this by running with the verbose flag:
REDWOOD_VERBOSE_TELEMETRY=true yarn create-redwood-app bazinga
Changes
typescript
is an explicit dependency ofrwjs/internal
. This is because we use it for detecting strict mode.What was happening was this import sequence:
crwa -> rwjs/structure -> rwjs/internal -> ts
Why is TS even imported here? Because of the import statement in rwjs/structure project.ts and host.ts:
(as a result, the formatting, etc. happened too)