Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change type of validateUniqueness #6387

Merged
merged 2 commits into from
Oct 3, 2022
Merged

Conversation

noire-munich
Copy link
Collaborator

@noire-munich noire-munich commented Sep 14, 2022

This is a minimalist fix.

Changes the type of validateUniqueness to match type declaration and fix error on optional fourth argument.

Change type of validateUniqueness to match type declaration and fix error on optional fourth argument.
Copy link
Contributor

@jtoar jtoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jtoar
Copy link
Contributor

jtoar commented Oct 1, 2022

@noire-munich any reason this one is still a draft?

@noire-munich noire-munich marked this pull request as ready for review October 3, 2022 08:41
@noire-munich
Copy link
Collaborator Author

@noire-munich any reason this one is still a draft?

None that I can remember :D
Thanks for the review!

@jtoar jtoar merged commit fc8ee95 into redwoodjs:main Oct 3, 2022
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Oct 3, 2022
@jtoar jtoar modified the milestones: next-release, v3.2.0 Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants