-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify content-type in Yoga CORS test #6234
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c6ba098. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 14 targets
Sent with 💌 from NxCloud. |
✅ Deploy Preview for redwoodjs-docs canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve this change, but do we also want to upgrade Yoga -- or I will do this in a separate PR? After this test is merged?
I figured the Renovate PR would start passing if we get this in |
So we can merge that one |
Perfect. Then I can do a PR for the additional error mask config options in a subsequent PR. |
Approved. Merging. |
Tests were failing when trying to upgrade @graphql-yoga/common because of this test case. Specifying content-type also for multi-value headers is the correct thing to do.