Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify content-type in Yoga CORS test #6234

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Aug 19, 2022

Tests were failing when trying to upgrade @graphql-yoga/common because of this test case. Specifying content-type also for multi-value headers is the correct thing to do.

@nx-cloud
Copy link

nx-cloud bot commented Aug 19, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c6ba098. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 14 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Aug 19, 2022

Deploy Preview for redwoodjs-docs canceled.

Name Link
🔨 Latest commit c6ba098
🔍 Latest deploy log https://app.netlify.com/sites/redwoodjs-docs/deploys/62ffa42c0012340008d76927

@Tobbe Tobbe added the release:fix This PR is a fix label Aug 19, 2022
@dthyresson dthyresson self-requested a review August 19, 2022 16:28
Copy link
Contributor

@dthyresson dthyresson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this change, but do we also want to upgrade Yoga -- or I will do this in a separate PR? After this test is merged?

Copy link
Member Author

Tobbe commented Aug 19, 2022

I figured the Renovate PR would start passing if we get this in

Copy link
Member Author

Tobbe commented Aug 19, 2022

So we can merge that one

@dthyresson
Copy link
Contributor

So we can merge that one

Perfect. Then I can do a PR for the additional error mask config options in a subsequent PR.

@dthyresson
Copy link
Contributor

Approved. Merging.

@dthyresson dthyresson merged commit d6995d5 into redwoodjs:main Aug 19, 2022
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Aug 19, 2022
@Tobbe Tobbe deleted the tobbe-yoga-cors-test branch August 19, 2022 16:38
jtoar pushed a commit that referenced this pull request Aug 22, 2022
jtoar pushed a commit that referenced this pull request Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants