Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(directive): Pass directiveArgs to mockExecution for transformers #5848

Merged
merged 2 commits into from
Jun 28, 2022
Merged

fix(directive): Pass directiveArgs to mockExecution for transformers #5848

merged 2 commits into from
Jun 28, 2022

Conversation

dac09
Copy link
Collaborator

@dac09 dac09 commented Jun 28, 2022

Fixes #5845

@dac09 dac09 requested a review from dthyresson June 28, 2022 15:46
@netlify
Copy link

netlify bot commented Jun 28, 2022 •
edited
Loading

✅ Deploy Preview for redwoodjs-docs canceled.

Name Link
🔨 Latest commit 3b383da
🔍 Latest deploy log https://app.netlify.com/sites/redwoodjs-docs/deploys/62bb2f41a1ab3a00096a6672

@dac09 dac09 added the release:fix This PR is a fix label Jun 28, 2022
@dthyresson dthyresson mentioned this pull request Jun 28, 2022
Closed
@dac09 dac09 enabled auto-merge (squash) June 28, 2022 16:41
@dac09 dac09 merged commit 8d31358 into main Jun 28, 2022
@dac09 dac09 deleted the fix/directive-transform-mock-args branch June 28, 2022 17:10
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Jun 28, 2022
@jtoar jtoar modified the milestones: next-release, v2.1.0 Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dthyresson dthyresson Awaiting requested review from dthyresson

Assignees

@dac09 dac09

Labels
release:fix This PR is a fix
Projects
Main
Status: Archived
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.

Transformer directive throws during test due to directiveArgs always undefined
2 participants
@dac09 @jtoar