Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(🧶): update engines property on yarn upgrade #4940

Conversation

virtuoushub
Copy link
Collaborator

@virtuoushub virtuoushub commented Mar 26, 2022

After running npx @redwoodjs/codemods@canary upgrade-yarn

noticed @renovate-bot complained when the engines property in package.json did not match that of repo.

Also noted by @noire-munich in #4822

@netlify
Copy link

netlify bot commented Mar 26, 2022

Deploy Preview for redwoodjs-docs ready!

Name Link
🔨 Latest commit ac48a66
🔍 Latest deploy log https://app.netlify.com/sites/redwoodjs-docs/deploys/626818ac74a6f100085cfaac
😎 Deploy Preview https://deploy-preview-4940--redwoodjs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@thedavidprice
Copy link
Contributor

Good catch. We've changed the CRWA template, so this should be adjusted to be the same.

@callingmedic911
Copy link
Member

Not directly related to this PR but this had me thinking: We can now remove dedupe step if the project is on yarn 3. What do you think @thedavidprice?

@thedavidprice
Copy link
Contributor

@callingmedic911 it's always recommended to run dedupe after install, add, remove, CI, etc. Prior to Yarn 3, we had to use npx yarn-deduplicate. Because dedupe is included in v3, we can run yarn dedupe.

…res__/default/output/package.json

Co-authored-by: David Price <thedavid@thedavidprice.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
Status: Archived
Development

Successfully merging this pull request may close these issues.

4 participants