Fix issue where generate scaffold would crash if using double quotes #3040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtoar
reviewed
Jul 15, 2021
|
@zackdotcomputer thanks for all your hard work here! |
thedavidprice
pushed a commit
that referenced
this pull request
Jul 15, 2021
…3040) * Fix issues where generate scaffold would crash if using double quotes * Failure to add set import should be skip, not pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yarn rw g scaffold Somethingwould crash if your Prettier config was set up to use"instead of'because of a regex that assumed'throughout the codebase.This both corrects that regex so it is flexible between the quotation styles and also adds a guard so that the scaffold process will complete even if that regex fails to match in the future.
Resolves #3027