Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router): Add missing dependency for RSC #11591

Merged
merged 5 commits into from
Sep 20, 2024

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Sep 19, 2024

Adding missing dependency react-server-dom-webpack to the @redwoodjs/router package. This should hopefully fix the following error some users have been seeing when trying to try out RSC:

node:internal/process/promises:391
    triggerUncaughtException(err, true /* fromPromise */);
    ^

[vite]: Rollup failed to resolve import "react-server-dom-webpack/client" from "/Users/tobbe/tmp/rw-rsc-long-way/node_modules/@redwoodjs/router/dist/rsc/RscRoutes.js".
This is most likely unintended because it can break your application at runtime.
If you do want to externalize this module explicitly add it to
`build.rollupOptions.external`
    at viteWarn (file:///Users/tobbe/tmp/rw-rsc-long-way/node_modules/vite/dist/node/chunks/dep-CUvs3bbV.js:65528:17)

react-server-dom-webpack is already a dependency of @redwoodjs/vite, but when I moved things from the vite package over to the router package I forgot to also copy over this dependency.

This mostly affects the experimental RSC feature. But because everyone will get the new dependency installed I didn't mark the PR with the "experimental" label

@Tobbe Tobbe added the release:fix This PR is a fix label Sep 19, 2024
@Tobbe Tobbe added this to the next-release-patch milestone Sep 19, 2024
@Tobbe Tobbe merged commit d2fe56c into redwoodjs:main Sep 20, 2024
50 checks passed
@Tobbe Tobbe deleted the tobbe-fix-router-add-missing-dependency branch September 20, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants