Default NODE_ENV to "development" if it's undefined when starting jobs worker
#11572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e jobs scripts Closes #11569
…her than dev/test. Backports to 8.0 and 8.1 docs
Josh-Walker-GM
approved these changes
Sep 16, 2024
Josh-Walker-GM
pushed a commit
that referenced
this pull request
Sep 19, 2024
…obs worker (#11572) This mimics the behavior of `yarn rw dev` where `NODE_ENV` will equal `development` if you don't set it explicitly. Because of this, you need to make sure you explicitly set it in other environments. You should set `NODE_ENV=production` in your `.env` file/Dockerfile on your production server, for example. The docs have been updated to note this. Closes #11569
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mimics the behavior of
yarn rw devwhereNODE_ENVwill equaldevelopmentif you don't set it explicitly.Because of this, you need to make sure you explicitly set it in other environments. You should set
NODE_ENV=productionin your.envfile/Dockerfile on your production server, for example. The docs have been updated to note this.Closes #11569