Docs: Use Redwood's hashPassword() for loginToken hashing in the password-less dbAuth flow #11566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hashing algorithm used in the current version of the guide doesn't match the algorithm that Redwood uses to find user by username/password before passing control to the custom login handler. This breaks login flow, users can never sign in even with a correct valid token. Introduced changes replace 3rd-party crypto-js library with the `hashPassword()` function imported from the Redwood itself.
antonmoiseev
changed the title
antonmoiseev
changed the title
|
I love consistency! But I actually think your original code with |
Josh-Walker-GM
pushed a commit
that referenced
this pull request
Sep 16, 2024
…word-less dbAuth flow (#11566)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hashing algorithm used in the current version of the guide doesn't match the algorithm that Redwood uses to find user by username/password before passing control to the custom login handler. This breaks login flow, users can never sign in even with a correct valid token.
Introduced changes replace 3rd-party crypto-js library with the
hashPassword()function imported from the Redwood itself.