Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rsc): Don't pass any props to the user's Routes #11539

Merged
merged 5 commits into from
Sep 12, 2024

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Sep 12, 2024

There's no need to pass the location as props to the routes component anymore as we now store it in server-storage and can read it with getLocation()

This is the main part of this PR:
image
https://github.com/redwoodjs/redwood/pull/11539/files#diff-13d61e6bc160d258f65d2b2e4d0e87d3b192b453d8e50e5e929dc7892e6706a1L132

@Tobbe Tobbe added the release:chore This PR is a chore (means nothing for users) label Sep 12, 2024
@Tobbe Tobbe added this to the chore milestone Sep 12, 2024
@Tobbe Tobbe merged commit 5995a4b into redwoodjs:main Sep 12, 2024
50 checks passed
@Tobbe Tobbe deleted the tobbe-rsc-no-routes-props branch September 12, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant