[gh11385] Updated the generated page template #11533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Josh-Walker-GM I could use your help with the tests (please) -- I updated the fixtures, but it looked like there was also a snapshot file that will need to be updated. |
Tobbe
reviewed
Sep 11, 2024
packages/cli/src/commands/generate/page/templates/page.tsx.template
Outdated
Show resolved
Hide resolved
packages/cli/src/commands/generate/page/__tests__/__snapshots__/page.test.js.snap
Outdated
Show resolved
Hide resolved
Tobbe
reviewed
Sep 11, 2024
Josh-Walker-GM
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
@ahaywood awesome. I tweaked a little as we discussed. If you want to sanity check and then merge it looks good to me!
Josh-Walker-GM
added a commit
that referenced
this pull request
Sep 16, 2024
Fixes #11385 ## Feature description When you create a brand new page, the template includes a `<Link />` to that page. ``` <p> My default route is named <code>upgradeGuide</code>, link to me with ` <Link to={routes.upgradeGuide()}>UpgradeGuide</Link>` </p> ``` If you already created a parameter with the routes.tsx file <Route path="/upgrade/{slug:string}" page={UpgradeGuideIndividualPage} name="upgradeGuideIndividual" /> Then, the first time you load the page in the browser, you'll get an error because you didn't specify a parameter within the Link Every once in a while this still throws me off. ## Analysis and Design I considered using a `<pre>` tag or a `<code>` tag, but it would still throw the same error. ## Solution description I updated all the templates to include the path within a comment. --------- Co-authored-by: Josh GM Walker <56300765+Josh-Walker-GM@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11385
Feature description
When you create a brand new page, the template includes a
<Link />to that page.If you already created a parameter with the routes.tsx file
Then, the first time you load the page in the browser, you'll get an error because you didn't specify a parameter within the Link Every once in a while this still throws me off.
Analysis and Design
I considered using a
<pre>tag or a<code>tag, but it would still throw the same error.Solution description
I updated all the templates to include the path within a comment.