-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(baremetal): Check available disk space #11469
Merged
Merged
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
48551b4
feat(baremetal): Check available disk space
Tobbe 8bb32d2
add --no-df test
Tobbe 1c146d0
changeset
Tobbe 2c259eb
freeSpaceRequired config
Tobbe 46f865a
Update docs and changeset
Tobbe 2e5807a
Include freeSpaceRequired in template
Tobbe 4e53e95
Warning for existing projects
Tobbe 2b964fe
Merge branch 'main' into tobbe-baremetal-df
Tobbe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
- feat(baremetal): Check available disk space (#11469) by @Tobbe | ||
|
||
Adds an early step to the `yarn rw deploy baremetal` command that checks to | ||
make sure there is enough free disk space on the server before continuing. | ||
|
||
By default it will make sure there is at least 2048 MB (2 GB) of free disk space | ||
but this can be changed by setting the new `deploy.toml` option | ||
`freeSpaceRequired` to however many MB you want. | ||
|
||
You can skip this step by passing `--no-df` to the `deploy baremetal` command or | ||
setting `freeSpaceRequired` to `0`. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This says
[optional]
but doesn't the task itself require it to exist? It only skips if the value is set to0
but what if you don't have the config option at all? Like if a person upgrades and doesn't this config var, what happens? Can it just also skip ifundefined
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I made it part of
DEFAULT_SERVER_CONFIG
. So if it's not set at all it will default to 2048 MB.