chore(rsc): Remove Node RSC worker #11449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobbe
added
release:chore
Tobbe
force-pushed
the
tobbe-rsc-remove-worker
branch
5 times, most recently
from
3315b2e
to
2af5b15
Compare
Tobbe
changed the title
Tobbe
force-pushed
the
tobbe-rsc-remove-worker
branch
from
a22337e
to
91910c7
Compare
Josh-Walker-GM
pushed a commit
that referenced
this pull request
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For production (
yarn rw serve) no Node worker is needed.We had it because it was a way to do RSC in the same process as SSR and have different loader conditions for RSC and SSR (setting
react-serverfor RSC).But this shouldn't be needed for prod, because all files are already built with the correct loader condition, so all imports are already resolved (as long as you include everything needed in the analyze/build phase).
So - getting rid of the worker here is cleaning up really old massive tech dept. And being able to run without the worker also means we've finally gotten our build process set up and configured correctly!