Highlight output commands #11343
Merged
Highlight output commands #11343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Tobbe I want these to be orange, I want the user to see them. Whether we call that a "warning" internally with the color palette is another discussion, but this is what I want the message to look like when someone creates a job.
We can/should be consistent with other generators, but I think it should start here: the other commands that are now enabled as a result of running this one are the most important part of this output, and if you don't read any other documentation at least you are now are aware of these.
If we're going to insist on tying specific meanings to colors this is always going to feel like a friction point, which may be why the
colorspackage itself doesn't do that. If I want to write something in red to really draw the user's attention to it I want to be able to that, without the code implying that I'm outputting an error message because I usedc.error. This is purely decorative for the console output, it shouldn't have any more weight than that.