chore(playwright): Make RSC tests less flakey #11325
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was running the tests locally with
--headed
I noticed that the tests would sometimes try to click the "Login" button before the page had updated with the password filled in. A short 300ms wait seems to have fixed that.Also noticed that after resetting the DB to run the tests with a clean slate users weren't seeded with the same IDs as the tests expected. So now the tests rely less on the ("random") ID assignment, and more on just the deterministic emails we have for the users