chore(lint): enable '@typescript-eslint/only-throw-error' #11260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Walker-GM
added
release:chore
Josh-Walker-GM
commented
Aug 15, 2024
Comment on lines
+21
to
+24
| const { RedwoodError, EmailValidationError } = require('@redwoodjs/api') as { | ||
| RedwoodError: typeof RedwoodErrorType | ||
| EmailValidationError: typeof EmailValidationErrorType | ||
| } |
There was a problem hiding this comment.
This is pretty ugly. Highlights the need to switch over to vitest where this would probably be a non-issue.
Tobbe
reviewed
Aug 15, 2024
Josh-Walker-GM
commented
Aug 15, 2024
| @@ -1,4 +1,5 @@ | |||
| { | |||
| "extends": "./tsconfig.compilerOption.json", | |||
| "exclude": ["dist", "node_modules", "**/__mocks__"] | |||
| "exclude": ["dist", "node_modules", "**/__mocks__"], | |||
| "include": ["**/*"] | |||
There was a problem hiding this comment.
Again just sort of iterating on this config. Likely not perfect.
Josh-Walker-GM
commented
Aug 15, 2024
| if (error) { | ||
| throw error | ||
| } | ||
| throw new Error('Unreachable code: FailureComponent without a Failure') |
There was a problem hiding this comment.
Throwing undefined would still have been an error that we'd have seen/heard of. I doubt anyone else has added something like Unreachable code: to our codebase before so it should be fairly easy to spot if this change results in an issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables
@typescript-eslint/only-throw-errorrule and addresses the resulting errors.Also updates the eslint tsconfig to handle test files.