Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove erronerous console.log("In decorators") in Storybook package #11141

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

Philzen
Copy link
Contributor

@Philzen Philzen commented Aug 2, 2024

Just upgraded Storybook to Vite and loving it.

Only got a little confused while migrating and developing stories about a re-occurring "In decorators" message appearing in my console.

As i assume this is not a mission critical line of code i'd hereby propose to remove it 😉

@ahaywood
Copy link
Contributor

ahaywood commented Aug 2, 2024

@Philzen Thanks for taking the time to file a PR! ❤️

PS Glad Storybook/Vite has been a good experience! -- Shout out to @arimendelow 😊

@ahaywood ahaywood added this to the next-release-patch milestone Aug 2, 2024
@arimendelow
Copy link
Contributor

Thanks for the PR @Philzen!!! I thought I had removed all my console logs but I guess not 😆

@Josh-Walker-GM Josh-Walker-GM added release:fix This PR is a fix changesets-ok Override the changesets check labels Aug 2, 2024
@Josh-Walker-GM Josh-Walker-GM enabled auto-merge (squash) August 2, 2024 19:54
@Josh-Walker-GM Josh-Walker-GM merged commit 0139a29 into redwoodjs:main Aug 2, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changesets-ok Override the changesets check release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants