fix(cli-cache): Remove RW CLI cache on upgrade #11135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Walker-GM
approved these changes
Aug 1, 2024
Josh-Walker-GM
pushed a commit
that referenced
this pull request
Aug 9, 2024
This change removes the redwood cli plugin cache in `.redwood/commandCache.json` on running `rw upgrade`. This prevents the redwood CLI from using outdated versions of CLI plugins, and is particularly important when they same alias. **Before** running `yarn rw sb` -> would use the outdated storybook-cli package, and error out. **After** with no commandCache, it'll create a new command cache, and attempt to install the new vite CLI
Josh-Walker-GM
pushed a commit
that referenced
this pull request
Aug 9, 2024
This change removes the redwood cli plugin cache in `.redwood/commandCache.json` on running `rw upgrade`. This prevents the redwood CLI from using outdated versions of CLI plugins, and is particularly important when they same alias. **Before** running `yarn rw sb` -> would use the outdated storybook-cli package, and error out. **After** with no commandCache, it'll create a new command cache, and attempt to install the new vite CLI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the redwood cli plugin cache in
.redwood/commandCache.jsonon runningrw upgrade.This prevents the redwood CLI from using outdated versions of CLI plugins, and is particularly important when they same alias.
Before
running
yarn rw sb-> would use the outdated storybook-cli package, and error out.After
with no commandCache, it'll create a new command cache, and attempt to install the new vite CLI