Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(auth): build tweaks and add missing devdep #10947

Merged
merged 1 commit into from
Jul 15, 2024
Merged

chore(auth): build tweaks and add missing devdep #10947

merged 1 commit into from
Jul 15, 2024

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Jul 15, 2024 •
edited
Loading

  • Use tsconfig.build.json for both ESM and CJS
  • Use tsconfig.types-cjs.json for generating types for CJS
  • Add missing type-fest dev dependency to @redwoodjs/auth
    • Pinned it to version 3.13.0 to not introduce any new package versions in our dependency tree. type-fest is used by a lot of packages. The package with the most recent version was resend, and they used 3.13.0

@Tobbe Tobbe added the release:chore This PR is a chore (means nothing for users) label Jul 15, 2024
@Tobbe Tobbe added this to the chore milestone Jul 15, 2024
@Tobbe Tobbe merged commit c1db834 into redwoodjs:main Jul 15, 2024
51 of 55 checks passed
@Tobbe Tobbe deleted the tobbe-auth-tweak-build branch July 15, 2024 08:57
dac09 pushed a commit to dac09/redwood that referenced this pull request Jul 15, 2024
Merge branch 'chore/vitepkg-dual' of github.com:dac09/redwood into ch…
c190f8f 
…ore/vitepkg-dual

* 'chore/vitepkg-dual' of github.com:dac09/redwood:
  chore(auth): build tweaks and add missing devdep (redwoodjs#10947)
  chore(web): tsconfig.build.json (redwoodjs#10946)
@Josh-Walker-GM Josh-Walker-GM modified the milestones: chore, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release:chore This PR is a chore (means nothing for users)
Projects
None yet
Milestone
v8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Tobbe @Josh-Walker-GM