-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce RSC "live reload." #10932
Merged
Merged
Introduce RSC "live reload." #10932
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
f618fd8
Add live reload client side code.
peterp 7fc7ae0
Add watcher for changes.
peterp d421292
Merge remote-tracking branch 'origin/main' into pp-rsc-live-reload
peterp c80a0c9
Fix imports.
peterp 61b2486
Fix dependencies.
peterp 667a336
Remove dependency on execa v9 IPC calls.
peterp 97935c0
Use default build functionality.
peterp fc82379
Clean up code.
peterp 1934e05
A few more style tweaks.
peterp 5646038
Merge remote-tracking branch 'origin/main' into pp-rsc-live-reload
peterp f9c7316
Fix dedupe issue.
peterp 7fa5ac7
Update packages/vite/src/streaming/streamHelpers.ts
Tobbe 1a303c5
Merge branch 'main' into pp-rsc-live-reload
Tobbe 38b3666
Merge branch 'main' into pp-rsc-live-reload
Tobbe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
import { getPaths } from '@redwoodjs/project-config' | ||
|
||
import { buildRouteHooks } from './buildRouteHooks' | ||
import { buildRouteManifest } from './buildRouteManifest' | ||
import { buildRscClientAndServer } from './buildRscClientAndServer' | ||
import { buildForStreamingServer } from './streaming/buildForStreamingServer' | ||
import { startLiveReload } from './watch' | ||
|
||
export async function build() { | ||
await buildRscClientAndServer({ verbose: false }) | ||
await buildForStreamingServer({ verbose: false }) | ||
await buildRouteHooks(false, getPaths()) | ||
await buildRouteManifest() | ||
} | ||
|
||
export async function initDevRscServer() { | ||
process.env.NODE_ENV = 'development' | ||
await startLiveReload() | ||
} | ||
|
||
initDevRscServer() | ||
.then(() => { | ||
console.log('we are ready', process.env.NODE_ENV) | ||
}) | ||
.catch((e) => { | ||
// | ||
console.log('oh no!', e) | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,120 @@ | ||
import http from 'node:http' | ||
|
||
import chokidar from 'chokidar' | ||
import { type ResultPromise } from 'execa' | ||
import { rimraf } from 'rimraf' | ||
|
||
import { getPaths } from '@redwoodjs/project-config' | ||
|
||
import { build } from './devRscServer' | ||
|
||
export const startLiveReload = async () => { | ||
const { execaNode } = await import('execa') | ||
|
||
let child: ResultPromise | ||
let client: http.ServerResponse | ||
|
||
const sendReloadEvent = () => { | ||
if (typeof client !== 'undefined') { | ||
client.write('event: reload\n') | ||
client.write('data: \n\n') | ||
} | ||
} | ||
|
||
const rwjsPaths = getPaths() | ||
|
||
const watcher = chokidar.watch('(web|api)/src/**/*.{ts,js,jsx,tsx}', { | ||
persistent: true, | ||
ignored: ['node_modules', '.redwood'], | ||
ignoreInitial: true, | ||
cwd: rwjsPaths.base, | ||
awaitWriteFinish: true, | ||
}) | ||
|
||
process.stdin.on('data', async (data) => { | ||
const str = data.toString().trim().toLowerCase() | ||
if (str === 'rs') { | ||
await rimraf.rimraf(rwjsPaths.web.dist) | ||
await rimraf.rimraf(rwjsPaths.api.dist) | ||
await build() | ||
|
||
try { | ||
child.kill() | ||
} catch (e) { | ||
console.log(e) | ||
} | ||
child = execaNode('../node_modules/@redwoodjs/vite/dist/runFeServer.js', { | ||
ipc: true, | ||
shell: true, | ||
stdio: 'inherit', | ||
}) | ||
if (typeof child !== 'undefined') { | ||
const m = await child.getOneMessage() | ||
if (m === 'server ready') { | ||
sendReloadEvent() | ||
} | ||
} | ||
|
||
try { | ||
await child | ||
} catch (e) { | ||
console.log('.....') | ||
} | ||
} | ||
}) | ||
|
||
watcher | ||
.on('ready', async () => { | ||
console.log('[live reload started]') | ||
await rimraf.rimraf(rwjsPaths.web.dist) | ||
await rimraf.rimraf(rwjsPaths.api.dist) | ||
await build() | ||
|
||
child = execaNode('../node_modules/@redwoodjs/vite/dist/runFeServer.js', { | ||
ipc: true, | ||
shell: true, | ||
stdio: 'inherit', | ||
}) | ||
|
||
http | ||
.createServer(async (_req, res) => { | ||
client = res | ||
res.writeHead(200, { | ||
'content-type': 'text/event-stream', | ||
'cache-control': 'no-cache', | ||
connection: 'keep-alive', | ||
'access-control-allow-origin': '*', | ||
}) | ||
}) | ||
.listen(8913) | ||
|
||
try { | ||
await child | ||
} catch (e) { | ||
console.log('.....') | ||
} | ||
}) | ||
.on('all', async (eventName, p) => { | ||
console.log('[live reload] event', eventName, p) | ||
await rimraf.rimraf(rwjsPaths.web.dist) | ||
await rimraf.rimraf(rwjsPaths.api.dist) | ||
await build() | ||
|
||
child.kill() | ||
child = execaNode('../node_modules/@redwoodjs/vite/dist/runFeServer.js', { | ||
ipc: true, | ||
}) | ||
if (typeof child !== 'undefined') { | ||
const m = await child.getOneMessage() | ||
if (m === 'server ready') { | ||
sendReloadEvent() | ||
} | ||
} | ||
|
||
try { | ||
await child | ||
} catch (e) { | ||
console.log('.....') | ||
} | ||
}) | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a command that will be executed by the Redwood CLI.