fix(dbAuth): Don't throw errors under normal auth flow conditions #10927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dac09
pushed a commit
to dac09/redwood
that referenced
this pull request
Jul 12, 2024
…iddleware * 'main' of github.com:redwoodjs/redwood: fix(docs): Fix introduction link (redwoodjs#10938) fix(cli-helpers): Fix CJS support (redwoodjs#10936) chore(cli-helpers): Formatting chore(cli-helpers): loadEnvFiles cleanup (redwoodjs#10935) feat(cli-helpers): Add loadEnvFiles (redwoodjs#10931) chore(cli-helpers): Fix dual package build. Align with new pattern (redwoodjs#10933) fix(dbAuth): Don't throw errors under normal auth flow conditions (redwoodjs#10927) chore(dbAuth): Fix typo in comment, and refactor dbAuthSession (redwoodjs#10928)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main issue I'm fixing here is that an error would be thrown if the user had some/any cookie set, but not valid session cookies.
Cookies expiring, cookies not being available, cookies having weird values are all common scenarios for any auth flow. They're not exceptional, so no exceptions should be raised (i.e. the code shouldn't throw an error).
The error messages we would throw are still helpful in some cases though during development. So I kept them around, but only print them as debug messages, and only when NODE_ENV is 'development'