Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(internal gql): Update types in test fixture #10918

Merged

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Jul 5, 2024

#10856 updated the gql codegen client preset, and with that new types are generated
https://github.com/dotansimha/graphql-code-generator/blob/master/packages/presets/client/CHANGELOG.md#430

This PR just updates the generated types in our test fixture.

They're updated when running tests, but because of NX caching it doesn't always happen. So it can be difficult to track down. But it was causing our canary publishing to fail

image

@Tobbe Tobbe added the release:chore This PR is a chore (means nothing for users) label Jul 5, 2024
@Tobbe Tobbe added this to the chore milestone Jul 5, 2024
@Tobbe Tobbe merged commit 2b18e22 into redwoodjs:main Jul 5, 2024
55 of 56 checks passed
@Tobbe Tobbe deleted the tobbe-gql-codegen-updated-generated-types branch July 5, 2024 10:17
dac09 pushed a commit to dac09/redwood that referenced this pull request Jul 6, 2024
…iddleware

* 'main' of github.com:redwoodjs/redwood:
  chore(server-store): Alias imports for getting request details to  `@redwoodjs/web/request` (redwoodjs#10904)
  chore(ci): Cleaner log when publishing, unless failure (redwoodjs#10919)
  chore(tests): Fix failing kitchen-sink tests by logging in (redwoodjs#10920)
  fix(internal gql): Update types in test fixture (redwoodjs#10918)
  debug(ci): Print publishing command output (redwoodjs#10916)
  chore(ci): Use more supported syntax in publish_canary script (redwoodjs#10915)
  chore(ci): Exit canary publishing if version cannot be determined (redwoodjs#10914)
@Josh-Walker-GM Josh-Walker-GM modified the milestones: chore, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants