Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Storybook Vite): Add JS project support #10900

Merged
merged 4 commits into from
Jul 19, 2024
Merged

feat(Storybook Vite): Add JS project support #10900

merged 4 commits into from
Jul 19, 2024

Conversation

arimendelow
Copy link
Contributor

@arimendelow arimendelow commented Jul 1, 2024 •
edited
Loading

This adds support to the SBV CLI for JS projects.

Testing:

  • Test with TS project
    • ✅ No change in behavior.


  • Test with JS project
    • 🟨 Currently blocked as generating a JS test project is broken on the convert to JS stage

@Josh-Walker-GM
Copy link
Collaborator

I've tested this locally (used 10962 to get a JS project). Everything seems to work great

@Josh-Walker-GM Josh-Walker-GM added the release:feature This PR introduces a new feature label Jul 18, 2024
@Josh-Walker-GM Josh-Walker-GM added this to the next-release milestone Jul 18, 2024
@Josh-Walker-GM Josh-Walker-GM marked this pull request as ready for review July 19, 2024 17:06
@Josh-Walker-GM Josh-Walker-GM merged commit b6426f6 into redwoodjs:main Jul 19, 2024
46 checks passed
This was referenced Jul 19, 2024
Draft
Merged
Josh-Walker-GM pushed a commit that referenced this pull request Jul 19, 2024
@arimendelow
chore(docs): Update Storybook Vite docs to reflect recent change (#10987
81153e6 
)

In #10900, we disabled the type declaration file created by the Auto
Import plugin used by Storybook Vite.

This PR updates the docs to reflect that.

Also fixed a typo :)
@Josh-Walker-GM Josh-Walker-GM modified the milestones: next-release, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Walker-GM Josh-Walker-GM Josh-Walker-GM approved these changes

Assignees
No one assigned
Labels
release:feature This PR introduces a new feature
Projects
None yet
Milestone
v8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@arimendelow @Josh-Walker-GM