Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(esm): Update storybook build and package.json to build dual package #10896

Merged
merged 2 commits into from
Jul 2, 2024
Merged

chore(esm): Update storybook build and package.json to build dual package #10896

merged 2 commits into from
Jul 2, 2024

Conversation

dac09
Copy link
Collaborator

@dac09 dac09 commented Jul 1, 2024

While doing the dual package work on @redwoodjs/web I noticed some misconfiguration on the storybook package.

This PR:

  1. Updates build script to produce both ESM and CJS output
  2. Updates the exports fields - some of these were pointing at files that didn't exist

@dac09 dac09 added the release:chore This PR is a chore (means nothing for users) label Jul 1, 2024
@dac09 dac09 added this to the chore milestone Jul 1, 2024
@dac09 dac09 merged commit ba93a45 into redwoodjs:main Jul 2, 2024
51 checks passed
@dac09 dac09 deleted the chore/storybook-esm-packaging branch July 2, 2024 05:31
Josh-Walker-GM pushed a commit that referenced this pull request Jul 23, 2024
@dac09 @Josh-Walker-GM
chore(esm): Update storybook build and package.json to build dual pac…
069de7a 
…kage (#10896)
@Josh-Walker-GM Josh-Walker-GM modified the milestones: chore, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tobbe Tobbe Tobbe approved these changes

Assignees
No one assigned
Labels
release:chore This PR is a chore (means nothing for users)
Projects
Bighorn Development
Archived in project
Milestone
v8.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dac09 @Tobbe @Josh-Walker-GM