Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(fixtures): change redwood versions in fixtures #10832

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

Josh-Walker-GM
Copy link
Collaborator

Problem
Security alerts are firing on the fixture projects. These projects list very old versions of redwoodjs and as such are triggering warnings for old transient dependencies.

Changes

  1. Switch to the "latest" tag in these fixtures.

Notes
It would be ideal if these fixtures were kept up to date like our main test project fixture. The fixtures changed here are used only for their structure and content - they don't currently undergo any yarn installs.

In the future I would suggest we remove these fixtures entirely if it is possible and convenient to do so.

@Josh-Walker-GM Josh-Walker-GM added release:chore This PR is a chore (means nothing for users) changesets-ok Override the changesets check labels Jun 17, 2024
@Josh-Walker-GM Josh-Walker-GM added this to the chore milestone Jun 17, 2024
@Josh-Walker-GM Josh-Walker-GM self-assigned this Jun 17, 2024
@Josh-Walker-GM Josh-Walker-GM changed the title chore(fixtures): change versions in fixtures chore(fixtures): change redwood versions in fixtures Jun 17, 2024
@Josh-Walker-GM Josh-Walker-GM merged commit 21dd456 into main Jun 17, 2024
51 of 52 checks passed
@Josh-Walker-GM Josh-Walker-GM deleted the jgmw/fixtures-change-versions branch June 17, 2024 19:13
Josh-Walker-GM added a commit that referenced this pull request Jun 18, 2024
Follow up to #10832. Use `canary` instead of `latest` because we still
get security alerts until our merged changes are released. Moving to
`canary` will mean that these will be dismissed more quickly.
Josh-Walker-GM added a commit that referenced this pull request Jun 25, 2024
**Problem**
Security alerts are firing on the fixture projects. These projects list
very old versions of redwoodjs and as such are triggering warnings for
old transient dependencies.

**Changes**
1. Switch to the "latest" tag in these fixtures.

**Notes**
It would be ideal if these fixtures were kept up to date like our main
test project fixture. The fixtures changed here are used only for their
structure and content - they don't currently undergo any yarn installs.

In the future I would suggest we remove these fixtures entirely if it is
possible and convenient to do so.
Josh-Walker-GM added a commit that referenced this pull request Jun 25, 2024
Follow up to #10832. Use `canary` instead of `latest` because we still
get security alerts until our merged changes are released. Moving to
`canary` will mean that these will be dismissed more quickly.
@Josh-Walker-GM Josh-Walker-GM modified the milestones: chore, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changesets-ok Override the changesets check release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant