fix(og-mw-setup): Fix typo in notes for og-middleware setup #10736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cannikin
reviewed
Jun 5, 2024
packages/cli/src/commands/setup/middleware/ogImage/ogImageHandler.ts
Outdated
Show resolved
Hide resolved
|
Good catch! I think there are some code things to update as well, when I used this command with the latest RSC updates I remember something not getting configured correctly and then having to go back in and modify by hand... |
…ler.ts Co-authored-by: Rob Cameron <cannikin@fastmail.com>
I tried it today, seemed to be ok, but if you spot it again let me know, can update this PR or do another one :) |
cannikin
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a typo when I tried this earlier, I think it the setup instructions should ask users to install on the web side, not the api :)