Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run smoke-tests on React 18 too #10729

Merged
merged 9 commits into from
Jun 5, 2024

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Jun 5, 2024

We're releasing with React 18, so we should continuously run our smoke-tests on React 18 too, to make sure everything works for the released stable version of the framework.

Ideally this can/will also be a step towards only having a single branch that we use for releasing and for development

@Tobbe Tobbe force-pushed the tobbe-downgrade-to-react-18 branch from 24b24d9 to 38a5203 Compare June 5, 2024 09:15
@Tobbe Tobbe added release:chore This PR is a chore (means nothing for users) changesets-ok Override the changesets check labels Jun 5, 2024
@Tobbe Tobbe changed the title Downgrade to React 18 Run smoke-tests on React 18 too Jun 5, 2024
@Tobbe Tobbe marked this pull request as ready for review June 5, 2024 11:06
@Tobbe Tobbe added this to the chore milestone Jun 5, 2024
@Tobbe Tobbe merged commit 88b4429 into redwoodjs:main Jun 5, 2024
51 of 52 checks passed
@Tobbe Tobbe deleted the tobbe-downgrade-to-react-18 branch June 5, 2024 11:33
@Josh-Walker-GM Josh-Walker-GM modified the milestones: chore, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changesets-ok Override the changesets check release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants