Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSC: Include <App> in SSR #10688

Merged
merged 53 commits into from
Jun 4, 2024
Merged

RSC: Include <App> in SSR #10688

merged 53 commits into from
Jun 4, 2024

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented May 28, 2024 •
edited
Loading

This PR makes it so that Redwood:

  • Switches to noExternal for the SSR build.
  • Adds --conditions node-server to the entire server process that does SSR (including RSC rendering during SSR)
  • Adds a bunch of dynamic imports, including react, from the SSR dist folder
  • Renders the Redwood framework shell and the Redwood app entry point (<App>) as client components
  • Renders a new SSR router as a client component
  • Calls renderToReadableStream, passing in files from the RSC build dist folder
  • Renders the ServerRouter, page layouts and pages as RSC components
  • Uses the bundler config (proxy) to read a bunch of client components
  • Calls createFromReadableStream.
  • Uses our webpack shim to load a bunch of client components
  • Renders all of that to HTML that is streamed to the client
  • Makes sure React can rehydrate on the client and pick up rendering using createFromFetch for RSC components

Some of the things mentioned above RW already did before this PR, but I just wanted to include it all to get the full flow documented

@Tobbe Tobbe mentioned this pull request May 28, 2024
Merged
@Tobbe Tobbe changed the title RSC: Cache client side navigation RSC: Include <App> in SSR May 28, 2024
Tobbe added 25 commits May 28, 2024 16:13
@Tobbe
Merge branch 'main' into tobbe-rsc-ssr-app
a5ae028
@Tobbe
Merge branch 'main' into tobbe-rsc-ssr-app
504d0c1
@Tobbe
More location.tsx comments
e125582
@Tobbe
Comments cleanup
2e09d81
@Tobbe
rsc is never enabled for buildForSTreamingServer
34b5024
@Tobbe
Remove unrelated change to server-router
b3698e1
@Tobbe
Go back to entry.server.tsx
7c8aa32
@Tobbe
Merge branch 'main' into tobbe-rsc-ssr-app
734028e
@Tobbe
more going back to entry.server
42724a7
@Tobbe
Reduce code churn
296d995
@Tobbe
Make build not crash (still doesn't do what we want though)
4a83313
@Tobbe
--wip-- [skip ci]
c0d0006
@Tobbe
Update noExternal comment in rscBuildForServer
9abf1f1
@Tobbe
chore(auth): Fix auth build
3bfcf4b
@Tobbe
Merge branch 'main' into tobbe-rsc-ssr-app
1da900a
@Tobbe
reference tsconfig.build
4ce3b80
@Tobbe
Merge branch 'main' into tobbe-rsc-ssr-app
d44e3ab
@Tobbe
chore: spelling, comment
e8058b8
@Tobbe
chore(exports): Seperate export for ServerAuthProvider
4a30a19
@Tobbe
Merge branch 'main' into tobbe-rsc-ssr-app
5648566
@Tobbe
chore(auth): Separate AuthProviderState export
a166abd
@Tobbe
chore(vite): dist imports from router
4f7d5eb
@Tobbe
chore(ServerInject): Named imports and source format
5c68ab3
@Tobbe
dynamic dist imports
fbac7ad
@Tobbe
Remove unneeded file
12e1d2f
@Tobbe Tobbe added the release:feature This PR introduces a new feature label Jun 3, 2024
@Tobbe Tobbe added this to the RSC milestone Jun 3, 2024
@Tobbe Tobbe added the changesets-ok Override the changesets check label Jun 3, 2024
@Tobbe Tobbe mentioned this pull request Jun 4, 2024
Merged
@Tobbe Tobbe marked this pull request as ready for review June 4, 2024 20:01
@Tobbe Tobbe merged commit 3580cc8 into redwoodjs:main Jun 4, 2024
46 checks passed
@Tobbe Tobbe deleted the tobbe-rsc-ssr-app branch June 4, 2024 20:20
@Tobbe Tobbe mentioned this pull request Jun 6, 2024
Merged
dac09 added a commit to dac09/redwood that referenced this pull request Jun 7, 2024
@dac09
Merge branch 'main' of github.com:redwoodjs/redwood into feat/move-se…
2e174c1 
…rver-store

* 'main' of github.com:redwoodjs/redwood:
  chore(deps): bump @fastify/reply-from from 9.4.0 to 9.8.0 (redwoodjs#10728)
  chore(deps): bump jose from 4.15.4 to 4.15.5 (redwoodjs#10726)
  chore(ci): Track `@redwoodjs/router` in RSC CI (redwoodjs#10727)
  chore(deps): bump ejs from 3.1.9 to 3.1.10 (redwoodjs#10725)
  RSC: Include `<App>` in SSR (redwoodjs#10688)
  chore(logging): Remove overly verbose logging (redwoodjs#10723)
  chore(formatting): Fix "check annotations" (redwoodjs#10722)
  chore(comment): Update comment to match implementation (redwoodjs#10720)
  chore(imports): Differentiate between React type import and method imports (redwoodjs#10721)
  chore(auth): auth-supabase-api dependency fixes (redwoodjs#10719)
@Josh-Walker-GM Josh-Walker-GM modified the milestones: RSC, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changesets-ok Override the changesets check release:feature This PR introduces a new feature
Projects
None yet
Milestone
v8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Tobbe @Josh-Walker-GM