-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Replay for smoke tests #10664
Use Replay for smoke tests #10664
Conversation
36c2e77
to
4e2fc84
Compare
|
5800c77
to
89179e5
Compare
c2595c2
to
8b84e98
Compare
@callingmedic911 Thanks for opening this PR! ... I know it's still in Draft mode, but I wanted to go ahead and point out that one of the things that we've been paying careful attention to with Replay in our repo is speed. So, as you're working on this, would you mind to pay special attention to that? ❤️ |
@ahaywood Hello! Do you mean the speed of CI runs here? Or the performance of the framework? Replay adds very little overhead for recording. As for the latter, Replay is soon shipping Performance Analysis, which would be really useful in finding performance regression in the framework. |
26c3c61
to
218e84a
Compare
218e84a
to
a0044eb
Compare
@dac09 followup on our "failing test on Replay" discussion: I have filed an issue internally and as a workaround, I'm running that test on Chromium instead. I tagged you guys because you have the most context, but feel free to pass and / or ask questions. :) |
@callingmedic911 I'm going to rope @Tobbe in to help provide additional context. |
@callingmedic911 Thanks for doing all the work of integrating Replay with our smoke tests |
I think we need to add the API keys! Getting failures on other PRs
|
…into feat/location-serverStore * 'feat/location-serverStore' of github.com:dac09/redwood: no need to repeat fullUrl Use Replay for smoke tests (redwoodjs#10664) chore(testing): Remove unused member in Props interface (redwoodjs#10699) fix(cli): Directive generator command was not creating files (redwoodjs#10698) Always execute the <Metadata> component on the client (redwoodjs#10271)
Looking into it. |
This reverts commit 14d9535.
This PR set up Replay for smoke tests. Dom integrated Replay in the past to debug hard-to-repro problems. There have been a lot of updates with Replay (Chromium instead of Firefox as base, new test suite dashboard, new CLI). Eventually, I want to set up Playwright (with Replay) for framework users but first for framework authors (you guys).
How do I access the Replay dashboard?
Dashboard home for RedwoodJS
How does the dashboard look?
Can you show me how you debug with Replay?
https://www.loom.com/share/6553abcaaaac489f999547cb76773134 (very rushed, tiny demo). Docs is also a good place to start: https://docs.replay.io/ (We rewrote that recently)
Other things to note: