Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ssr): Make entry.client.tsx better match standard entry.client #10652

Merged
merged 2 commits into from
May 20, 2024

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented May 20, 2024

A while ago a check for null app element was added to the standard entry.client.tsx file. This PR adds that same check to the version of entry.client.tsx that's used when setting up SSR

@Tobbe Tobbe added the release:chore This PR is a chore (means nothing for users) label May 20, 2024
@Tobbe Tobbe added this to the SSR milestone May 20, 2024
@Tobbe Tobbe added the changesets-ok Override the changesets check label May 20, 2024
@Tobbe Tobbe enabled auto-merge (squash) May 20, 2024 04:10
@Tobbe Tobbe added the fixture-ok Override the test project fixture check label May 20, 2024
@Tobbe Tobbe merged commit 6d82f32 into redwoodjs:main May 20, 2024
51 of 52 checks passed
@Tobbe Tobbe deleted the tobbe-ssr-setup branch May 20, 2024 04:20
dac09 added a commit to dac09/redwood that referenced this pull request May 21, 2024
…tuples-dbauth-mw

* 'main' of github.com:redwoodjs/redwood:
  fix(deps): update dependency isbot to v5 (redwoodjs#10340)
  chore(deps): update dependency vscode-languageserver-protocol to v3.17.5 (redwoodjs#10351)
  chore(deps): update node.js to >=14.17 <=20.13 (redwoodjs#10368)
  fix(deps): update dependency graphql-sse to v2.5.3 (redwoodjs#10364)
  chore(deps): update dependency @supabase/supabase-js to v2.43.2 (redwoodjs#10365)
  chore(deps): update babel monorepo to v7.24.5 (redwoodjs#10614)
  fix(vite): Rename `serverAuthContext` to `serverAuthState` (redwoodjs#10653)
  feat(middleware): Add .shortCircuit to MiddlewareResponse (redwoodjs#10586)
  chore(ssr): Make entry.client.tsx better match standard entry.client (redwoodjs#10652)
  patch(crwa): Fix small annoyances (formatting, spell-check) (redwoodjs#10651)
  chore(ci): Update rsc readme (redwoodjs#10650)
  chore(serverAuth): Rename serverAuthContext to serverAuthState where relevant (redwoodjs#10643)
  chore(deps): Remove unused deps from prerender (redwoodjs#10649)
  Add missing rwjs/auth deps (redwoodjs#10648)
  feat(rsc-auth): Implement serverStore to hold and pass req info to RSC (redwoodjs#10585)
  chore(deps): Remove unused octokit package (redwoodjs#10645)
  chore(deps): bump @fastify/reply-from from 9.4.0 to 9.8.0 (redwoodjs#10644)
@Josh-Walker-GM Josh-Walker-GM modified the milestones: SSR, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changesets-ok Override the changesets check fixture-ok Override the test project fixture check release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants