Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mw): Pass matched params in invokeOptions in runFeServer #10571

Merged
merged 2 commits into from
May 15, 2024
Merged

fix(mw): Pass matched params in invokeOptions in runFeServer #10571

merged 2 commits into from
May 15, 2024

Conversation

dac09
Copy link
Collaborator

@dac09 dac09 commented May 14, 2024

@dthyresson and I found that we weren't passing matched params to middleware on POST requests.

This PR ensures that params found from middleware routing are passed to middleware on invocation.

@dac09 dac09 added the release:fix This PR is a fix label May 14, 2024
@dac09 dac09 added this to the SSR milestone May 14, 2024
@dac09 dac09 requested a review from dthyresson May 14, 2024 15:13
@dac09 dac09 self-assigned this May 14, 2024
dthyresson
dthyresson approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@dthyresson dthyresson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

As Danny noted, this was necessary to ensure route matching.

@dthyresson dthyresson added the changesets-ok Override the changesets check label May 14, 2024
@dthyresson dthyresson enabled auto-merge (squash) May 14, 2024 17:45
@dthyresson dthyresson merged commit 60484c1 into redwoodjs:main May 15, 2024
46 checks passed
@Josh-Walker-GM Josh-Walker-GM modified the milestones: SSR, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dthyresson dthyresson dthyresson approved these changes

Assignees

@dac09 dac09

Labels
changesets-ok Override the changesets check release:fix This PR is a fix
Projects
Bighorn Development
Archived in project
Milestone
v8.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dac09 @dthyresson @Josh-Walker-GM