Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rsc): Remove entries file setup step and remove from test fixtures #10549

Merged

Conversation

Josh-Walker-GM
Copy link
Collaborator

Problem
This is a follow up to #10533 which removed the need for the entries.ts file. That PR failed to remove the file from both the existing RSC test fixtures and the setup command.

Changes

  1. Removes the entries.ts file from the RSC test fixtures
  2. Removes the step in the RSC setup command that adds the entries.ts file to a project.

@Josh-Walker-GM Josh-Walker-GM added release:fix This PR is a fix changesets-ok Override the changesets check labels May 7, 2024
@Josh-Walker-GM Josh-Walker-GM added this to the RSC milestone May 7, 2024
@Josh-Walker-GM Josh-Walker-GM self-assigned this May 7, 2024
@Josh-Walker-GM Josh-Walker-GM marked this pull request as ready for review May 7, 2024 15:16
@Josh-Walker-GM
Copy link
Collaborator Author

@Tobbe I'm going to just merge this given we agreed on the underlying #10533 and CI is happy with this change.

@Josh-Walker-GM Josh-Walker-GM merged commit e07e6b0 into main May 7, 2024
46 checks passed
@Josh-Walker-GM Josh-Walker-GM deleted the jgmw/rsc-entries-file-remove-setup-and-fixtures branch May 7, 2024 15:17
@Josh-Walker-GM Josh-Walker-GM modified the milestones: RSC, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changesets-ok Override the changesets check release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant