Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invisible tags in MetaTag & Metadata JSDoc #10504

Merged
merged 3 commits into from
Apr 23, 2024

Conversation

Philzen
Copy link
Contributor

@Philzen Philzen commented Apr 23, 2024

Fixes the common pitfall that tags of all kind are not visible in JSDoc view b/c it will try to interpret them as HTML.

Before:
grafik

After:
grafik

@Tobbe
Copy link
Member

Tobbe commented Apr 23, 2024

Thanks @Philzen I'll make sure to get this merged!

@Tobbe Tobbe added release:chore This PR is a chore (means nothing for users) release:fix This PR is a fix and removed release:chore This PR is a chore (means nothing for users) labels Apr 23, 2024
@Tobbe Tobbe added this to the next-release-patch milestone Apr 23, 2024
@Josh-Walker-GM Josh-Walker-GM merged commit 6c02a5a into redwoodjs:main Apr 23, 2024
45 checks passed
@Philzen Philzen deleted the patch-21 branch April 23, 2024 21:44
Josh-Walker-GM pushed a commit that referenced this pull request Apr 29, 2024
Fixes the common pitfall that tags of all kind are not visible in JSDoc
view b/c it will try to interpret them as HTML.

Before:

![grafik](https://github.com/redwoodjs/redwood/assets/1634615/2d89e44c-fe34-4e41-901b-34ffe3f3628a)

After:

![grafik](https://github.com/redwoodjs/redwood/assets/1634615/4d0f1814-133f-4d14-9c0f-d77799012ab5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants