Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert React 19 upgrade (#10482 and #10491) #10495

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Revert React 19 upgrade (#10482 and #10491) #10495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0d8efd
Revert "fix(deps): update React to latest canary 19.x (#10482)"
Tobbe Apr 22, 2024
992a882
Revert "fix(upgrade): Download yarn patches (#10491)"
Tobbe Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,10 +237,6 @@ jobs:

- name: Run `rw build --no-prerender`
run: |
yarn why @apollo/client
tree .yarn
tree node_modules/@apollo/client/react/hooks/internal
cat node_modules/@apollo/client/react/hooks/internal/useRenderGuard.js
yarn rw build --no-prerender
working-directory: ${{ steps.set-up-test-project.outputs.test-project-path }}

Expand Down
35 changes: 0 additions & 35 deletions .yarn/patches/@apollo-client-npm-3.9.9-15c2e13518.patch
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions .yarn/patches/@storybook-react-dom-shim-npm-7.6.17-789bc900f0.patch
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions __fixtures__/fragment-test-project/web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
"@redwoodjs/router": "7.0.0",
"@redwoodjs/web": "7.0.0",
"humanize-string": "2.1.0",
"react": "19.0.0-canary-36e62c603-20240418",
"react-dom": "19.0.0-canary-36e62c603-20240418"
"react": "18.3.0-canary-a870b2d54-20240314",
"react-dom": "18.3.0-canary-a870b2d54-20240314"
},
"devDependencies": {
"@redwoodjs/vite": "7.0.0",
Expand Down
35 changes: 0 additions & 35 deletions __fixtures__/test-project-rsa/.yarn/patches/@apollo-client-npm-3.9.9-15c2e13518.patch
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions __fixtures__/test-project-rsa/web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
"@redwoodjs/forms": "8.0.0-canary.144",
"@redwoodjs/router": "8.0.0-canary.144",
"@redwoodjs/web": "8.0.0-canary.144",
"react": "19.0.0-canary-36e62c603-20240418",
"react-dom": "19.0.0-canary-36e62c603-20240418"
"react": "18.3.0-canary-a870b2d54-20240314",
"react-dom": "18.3.0-canary-a870b2d54-20240314"
},
"devDependencies": {
"@redwoodjs/vite": "8.0.0-canary.144",
Expand Down
35 changes: 0 additions & 35 deletions ...t-rsc-external-packages-and-cells/.yarn/patches/@apollo-client-npm-3.9.9-15c2e13518.patch
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions __fixtures__/test-project-rsc-external-packages-and-cells/web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
"@redwoodjs/web": "7.0.0-canary.1011",
"@tobbe.dev/rsc-test": "0.0.5",
"client-only": "0.0.1",
"react": "19.0.0-canary-36e62c603-20240418",
"react-dom": "19.0.0-canary-36e62c603-20240418"
"react": "18.3.0-canary-a870b2d54-20240314",
"react-dom": "18.3.0-canary-a870b2d54-20240314"
},
"devDependencies": {
"@redwoodjs/vite": "7.0.0-canary.1011",
Expand Down
35 changes: 0 additions & 35 deletions __fixtures__/test-project/.yarn/patches/@apollo-client-npm-3.9.9-15c2e13518.patch
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions ...xtures__/test-project/.yarn/patches/@storybook-react-dom-shim-npm-7.6.17-789bc900f0.patch
View file
Open in desktop

This file was deleted.

5 changes: 1 addition & 4 deletions __fixtures__/test-project/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,5 @@
"prisma": {
"seed": "yarn rw exec seed"
},
"packageManager": "yarn@4.1.1",
"resolutions": {
"@storybook/react-dom-shim@npm:7.6.17": "patch:@storybook/react-dom-shim@npm%3A7.6.17#~/.yarn/patches/@storybook-react-dom-shim-npm-7.6.17-789bc900f0.patch"
}
"packageManager": "yarn@4.1.1"
}
Loading
Loading