Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(middleware): Fix some internal types, spelling etc #10415

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Apr 4, 2024

Can't use optional chaining here
image
More info: microsoft/TypeScript#35236

I get this error, so I removed @ts-expect-error
image

@Tobbe Tobbe added the release:chore This PR is a chore (means nothing for users) label Apr 4, 2024
@Tobbe Tobbe added this to the SSR milestone Apr 4, 2024
@Tobbe Tobbe added the changesets-ok Override the changesets check label Apr 4, 2024
@@ -23,6 +23,7 @@
"peacock.color": "#b85833",
"cSpell.words": [
"autoplay",
"bazinga",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol, Thank you! 🤣

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's now an official Redwood word 😄

Copy link
Collaborator

@dac09 dac09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Tobbe Tobbe enabled auto-merge (squash) April 4, 2024 10:55
@Tobbe Tobbe merged commit 61ac910 into redwoodjs:main Apr 4, 2024
51 of 59 checks passed
@Tobbe Tobbe deleted the tobbe-middleware-ts-etc-fixes branch April 7, 2024 17:26
@Josh-Walker-GM Josh-Walker-GM modified the milestones: SSR, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changesets-ok Override the changesets check release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants