RSC: Vite plugin for route loading #10252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Walker-GM
added
release:fix
Tobbe
reviewed
Mar 17, 2024
packages/vite/src/plugins/vite-plugin-rsc-routes-auto-loader.ts
Outdated
Show resolved
Hide resolved
Tobbe
approved these changes
Mar 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We have to be smarter about how we automatically load route pages during dev. As a result, we have refactored out the logic into a vite plugin which has access to knowledge about whether it is being built for (or served for) SSR.
Changes
reactvite plugin back into the root config inindex.tsas it no longer has to be specifically applied in the various vite build or create calls.