RSC: vite/clientSsr #10238
Merged
RSC: vite/clientSsr #10238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobbe
force-pushed
the
tobbe-rsc-vite-ssr
branch
3 times, most recently
from
b1e88c1
to
163d02b
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Tobbe
force-pushed
the
tobbe-rsc-vite-ssr
branch
6 times, most recently
from
d3a8f4d
to
1e8f9cf
Compare
Tobbe
force-pushed
the
tobbe-rsc-vite-ssr
branch
2 times, most recently
from
6e1ff6b
to
d47d3b4
Compare
Tobbe
force-pushed
the
tobbe-rsc-vite-ssr
branch
from
d47d3b4
to
93fc69d
Compare
Tobbe
added
changesets-ok
Tobbe
force-pushed
the
tobbe-rsc-vite-ssr
branch
from
b0ea8da
to
cd3a18f
Compare
It's not really about external/noExternal here. It's about only using one version of the library, and one that's built with the right conditions. rsdw will import React, so it's important that it imports the same version of React as we are. If we're pulling rsdw from node_modules (which we would if we didn't get it from the dist folder) we'd also get the node_modules version of React. But the app itself already uses the bundled version of React, so we can't do that, because then we'd have to different Reacts where one isn't initialized properly |
Tobbe
force-pushed
the
tobbe-rsc-vite-ssr
branch
from
e5f4bb2
to
53c1234
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new function called
renderFromDistthat is ment to be used during SSR. It's supposed to do whatrenderFromRscServerdoes during normal browsing.renderFromDistinternally will directly read files out of thedist/rsc/directory (hence the name). During normal browsing the RSC server would read those files and construct a flight stream using them. During SSR we can directly read them and userenderToReadableStreamto build that flight stream. And then usecreateFromReadableStreaminstead ofcreateFromFetchto create a React Component from that flight data.