Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vite): upgrade to v5 #10197

Merged
merged 1 commit into from
Mar 11, 2024
Merged

feat(vite): upgrade to v5 #10197

merged 1 commit into from
Mar 11, 2024

Conversation

jtoar
Copy link
Contributor

@jtoar jtoar commented Mar 11, 2024

Redoing #10167 since I've split out some of the changes in #10196 and want a cleaner commit history to debug CI.

@jtoar jtoar mentioned this pull request Mar 11, 2024
Closed
1 task
@jtoar jtoar added the release:feature This PR introduces a new feature label Mar 11, 2024
@jtoar jtoar added this to the next-release milestone Mar 11, 2024
@jtoar jtoar marked this pull request as ready for review March 11, 2024 15:26
@jtoar
Copy link
Contributor Author

jtoar commented Mar 11, 2024

The SSR smoke test that's failing is really puzzling. Since it passes the rest of CI, I'm going to merge this and see if it's just because we need a new canary out. If that doesn't work, I'll revert, but I'm a bit out of ideas at the moment.

@jtoar jtoar added the changesets-ok Override the changesets check label Mar 11, 2024
@jtoar jtoar merged commit 4fd86e8 into main Mar 11, 2024
73 of 86 checks passed
@jtoar jtoar deleted the ds-vite/upgrade-to-v5 branch March 11, 2024 15:40
This was referenced Mar 11, 2024
Closed
Merged
jtoar added a commit that referenced this pull request Mar 11, 2024
@jtoar
fix(rsc): try fixing dev (#10202)
edbbf7b 
Based on #10201, it looks like
CI wasn't correctly catching the errors in the [Vite v5
upgrade](#10197) as far as RSC
goes at least. Had some success with configuring this plugin locally.
jtoar added a commit that referenced this pull request Mar 12, 2024
@jtoar
feat(vite): upgrade to v5 (#10197)
e11d73e 
Redoing #10167 since I've split
out some of the changes in
#10196 and want a cleaner
commit history to debug CI.
@jtoar jtoar added release:breaking This PR is a breaking change and removed release:feature This PR introduces a new feature labels Mar 14, 2024
jtoar added a commit that referenced this pull request Mar 14, 2024
@jtoar
Revert "feat(vite): upgrade to v5 (#10197)"
97a2aeb 
This reverts commit e11d73e.
@jtoar jtoar mentioned this pull request Apr 9, 2024
Merged
@Josh-Walker-GM Josh-Walker-GM mentioned this pull request May 2, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changesets-ok Override the changesets check release:breaking This PR is a breaking change
Projects
None yet
Milestone
v8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jtoar @Josh-Walker-GM